Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup last layer for GPU images #2

Merged
merged 2 commits into from
Feb 17, 2022
Merged

Setup last layer for GPU images #2

merged 2 commits into from
Feb 17, 2022

Conversation

pacospace
Copy link
Member

@pacospace pacospace commented Feb 15, 2022 •
edited
Loading

Related-To: os-climate/aicoe-osc-demo#91
Related-To: os-climate/aicoe-osc-demo#128

This will be the last layer used to build GPU images that have Neural magic for training.

Add initial files
f66adc7 
Signed-off-by: Francesco Murdaca <[email protected]>
@pacospace pacospace changed the title Setup last layer Setup last layer for GPU images Feb 15, 2022
@pacospace pacospace requested a review from harshad16 February 15, 2022 08:53
@pacospace
Copy link
Member Author

@harshad16 PTAL :)

harshad16
harshad16 suggested changes Feb 16, 2022
View reviewed changes
Copy link

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
just one minor fix needed

.s2i/environment Show resolved Hide resolved
@pacospace pacospace requested a review from harshad16 February 16, 2022 20:00
@harshad16
Copy link

@pacospace the ci check this pr has requires contributor to have signed commits.
As we committed the suggestions they are breaking.
you might have to squash the commits into one.

Add requirements
a0e43fb 
Signed-off-by: Francesco Murdaca <[email protected]>
@pacospace pacospace force-pushed the fmurdaca/setup-last-layer branch from 32d00bc to a0e43fb Compare February 17, 2022 13:58
@pacospace
Copy link
Member Author

@pacospace the ci check this pr has requires contributor to have signed commits. As we committed the suggestions they are breaking. you might have to squash the commits into one.

Thanks @harshad16, I squashed them.

@erikerlandson erikerlandson merged commit b79b1a6 into os-climate:main Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshad16 harshad16 Awaiting requested review from harshad16

Assignees

@harshad16 harshad16

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pacospace @harshad16 @erikerlandson